https://bugzilla.redhat.com/show_bug.cgi?id=1869719 --- Comment #6 from Pavel Valena <pvalena@xxxxxxxxxx> --- Thank you both for your reviews! I've added %bcond_with to disable the tests once ruby-vips is in Fedora (the test suite suceeds without skips). > There is some documentation in `doc` directory in the image_processing project that I think should be included since it looks like it has more content than the generated docs. Oh, you mean the upstream `doc` directory. Well, feel free to create a PR to add documentation into the gem (either generated, like other gems, or just the *.md files; that's up to the upstream). > This `%{gem_instdir}/image_processing.gemspec` could use a macro so it becomes `%{gem_instdir}/%{gem_name}.gemspec`. Sure, can be both ways (updated). _ _ _ _ > * `skip` vs `return` To me, the benefit of `skip` is that I see "SSSSSSSSS" in the test output, so I know the tests are skipped actually. `return` would just hide the issue, right? > * Unversioned `%gemspec_remove` It fails actually: https://gist.github.com/pvalena/aeda48c6fa786f2f3d41f996c3a6c11a An like I wrote previously, I'll not be running %gemspec_remove anyway, once ruby-vips is in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
