https://bugzilla.redhat.com/show_bug.cgi?id=1868991 --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Mat Booth from comment #6) > Thanks for the updates, just two nits remaining: > > > 1) The OSGi metadata does not export the jakarta.el package, because line 69 > completely overwrites the Export-Package value, not append to it. On line 69 > you want: > > '<Export-Package>jakarta.el,javax.el;version="3.0.0"</Export-Package>' > > To ensure it exports both old and new packages. Good catch, will fix. > 2) The Java guidelines state that if the package provides multiple JAR > files, they SHOULD be installed in a %{name} subdirectory (of %{_javadir}) > > So I would prefer if lines 85 and 86 read like this instead: > > %mvn_file :jakarta.el %{name}/jakarta.el glassfish-el > %mvn_file :jakarta.el-api %{name}/jakarta.el-api glassfish-el-api > > Or slightly more concisely: > > %mvn_file :{jakarta.el} %{name}/@1 glassfish-el > %mvn_file :{jakarta.el-api} %{name}/@1 glassfish-el-api > > And that would result in the following: > > /usr/share/java/glassfish-el.jar -> ./jakarta-el/jakarta.el.jar > /usr/share/java/glassfish-el-api.jar -> ./jakarta-el/jakarta.el-api.jar > /usr/share/java/jakarta-el > /usr/share/java/jakarta-el/jakarta.el.jar > /usr/share/java/jakarta-el/jakarta.el-api.jar Well, those two JARs are shipped by two *different* packages though? Wasn't that the whole reason for splitting out -api as a subpackage? It's also how it is currently handled in glassfish-el. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
