[Bug 1870208] Review Request: rubygem-ruby-vips - Ruby extension for the vips image processing library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1870208



--- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* `BuildRequires: vips-devel`
  - What is the reason to include vips-devel instead of just vips?

* Requires
  - I think there should be something aka `Requires: vips`
  - Possibly, there could be required all libraries loaded via `ffi_lib` call.

BTW, I'd rather see requires such as 'libvips.so.42`, but they are not properly
required [1].

* Wrong shebangs:

~~~
rubygem-ruby-vips-doc.noarch: E: env-script-interpreter
/usr/share/gems/gems/ruby-vips-2.0.17/example/example1.rb /usr/bin/env ruby
rubygem-ruby-vips-doc.noarch: E: env-script-interpreter
/usr/share/gems/gems/ruby-vips-2.0.17/example/thumb.rb /usr/bin/env ruby
~~~




[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1870275


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux