[Bug 1868846] Review Request: fcitx5 - Next generation of fcitx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1868846

Jerry James <loganjerry@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |loganjerry@xxxxxxxxx



--- Comment #7 from Jerry James <loganjerry@xxxxxxxxx> ---
(In reply to Qiyu Yan from comment #5)
> (In reply to Andy Mender from comment #4)
> > - Requires: %{name}%{?_isa} = %{version}-%{release} in fcitx5-libs          
> > # not a big issue, but adding this will prevent accidental installs of
> > fcitx5-libs alone.
> Reasonable, fixed

Now the main package has:

Requires:       %{name}-libs%{?_isa} = %{version}-%{release}

and the libs subpackage has:

Requires:       %{name}%{?_isa} = %{version}-%{release}

which means that installing either package gives you both.  In that case, what
is the point in even having a libs subpackage?  It looks to me as though the
second of the two Requires (the one just added to the libs subpackage) is
wrong.  Not having it means that other programs can link to the library and not
drag in the binaries in the main package.  I think you should remove that
Requires again.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux