https://bugzilla.redhat.com/show_bug.cgi?id=1862554 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST CC| |zbyszek@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zbyszek@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- + package name is OK + latest version + license is acceptable for Fedora (MIT) + license is specified correctly + builds and installs OK + rust2rpm was used, so the packaging is standard Issues: Summary is longer than ~70 characters. Something like "Library for Javascript Object Signing and Encryption, JSON Web Tokens, JSON Web Signature and Encryption" would be better. rpmlint: rust-biscuit-devel.noarch: E: summary-too-long C Library to work with Javascript Object Signing and Encryption(JOSE), including JSON Web Tokens (JWT), JSON Web Signature (JWS) and JSON Web Encryption (JWE) See above. rust-biscuit-devel.noarch: W: invalid-url URL: https://crates.io/crates/biscuit HTTP Error 404: Not Found Bogus. rust-biscuit-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/biscuit-0.5.0-beta2/.cargo-checksum.json OK. rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/CHANGELOG.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/LICENSE rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/README.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/doc/README.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/doc/supported.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/digest.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/errors.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/helpers/mod.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/helpers/presence.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/helpers/temporal_options.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/helpers/validation.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/jwa.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/jwe.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/jwk.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/jws.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/lib.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/macros.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/base64_url_uint.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/byte_sequence.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/mod.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/option_base64_url_uint.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/serde_custom/option_byte_sequence.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/src/test.rs rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/test/fixtures/jwk_private_key.json rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/test/fixtures/jwk_public_key.json rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/test/fixtures/rsa_private_key.pem rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/cargo/registry/biscuit-0.5.0-beta2/test/fixtures/rsa_public_key.pem rust-biscuit-devel.noarch: W: spurious-executable-perm /usr/share/doc/rust-biscuit-devel/README.md rust-biscuit-devel.noarch: E: script-without-shebang /usr/share/licenses/rust-biscuit-devel/LICENSE It seems that the executable bit is set on those files. This should be fixed upstream. Package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
