https://bugzilla.redhat.com/show_bug.cgi?id=1868846 --- Comment #5 from Qiyu Yan <yanqiyu01@xxxxxxxxx> --- (In reply to Andy Mender from comment #4) > Overall looks great! > > Two items remaining: > - Requires: %{name}%{?_isa} = %{version}-%{release} in fcitx5-libs > # not a big issue, but adding this will prevent accidental installs of > fcitx5-libs alone. Reasonable, fixed > - fcitx5.x86_64: W: conffile-without-noreplace-flag > /etc/X11/xinit/xinput.d/fcitx5.conf # if I understand correctly, as it > stands now fcitx5 updates can accidentally override the fcitx5.conf config. > We probably don't want that. I am not sure if it is good to let users to change the xinputrc script, but giving users more powers are always good, fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx