https://bugzilla.redhat.com/show_bug.cgi?id=1868847 --- Comment #3 from Qiyu Yan <yanqiyu01@xxxxxxxxx> --- (In reply to Jerry James from comment #2) > Package Review > ============== > > Legend: > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated > > ===== Issues ==== > > - The most recent changelog entry has the wrong embedded date. It should be > 20200812 but is 20200811. This is because the forge macros embed the > current > date, so if you rebuild the package on a different day, you get a different > embedded date. I like to add '%global date <date>' when using the forge > macros to avoid this. The date seems comes from git log information of the change date of the %global commit xxx line, and the date is not independent with the time zone (I can't predict what date will be generated on copr nor koij) but it seems rpm macros mataincers are doing some change in recent versions, for example: - https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-32-x86_64/01612195-fcitx5-configtool/ - https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-rawhide-x86_64/01612195-fcitx5-configtool/ the two builds, the rawhide one don't have the date any more, while I think I am bumping 0-0.N --> 0-0.(N+1) on every new version, the release strings will still work (no matter the forge macro changes like what) > > - The devel subpackage creates two unowned directories: %{_includedir}/Fcitx5 > and %{_datadir}/gir-1.0. Change the "%files devel" to be: > > %{_includedir}/Fcitx5/ I think this should be owned by fcitx5-devel, and headers provided by all fcitx5-*-devel used headers in fcitx5-devel, I am adding explicit requires to fcitx5-*-devel > %{_datadir}/gir-1.0/ dnf provides `rpm --eval %{_datadir}/gir-1.0` gives me a long list, this package is owning the folder too. > > - Rpmlint is complaining that the Summary line for the devel subpackage is > longer than the description. Change the first word of the description to > "Development" and that complaint will go away. Fixed > > - The explicit Requires on fcitx5, gtk2, and gtk3 should be removed. See Fixed, also for fcitx5-*, will update bugzilla tickets later > [!]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/include/Fcitx5, > /usr/share/gir-1.0 Should be fixed > [!]: Requires correct, justified where necessary. Fixed > [!]: Final provides and requires are sane (see attachments). Fixed > [!]: %check is present and all tests pass. > Upstream did not provide any tests, so this is expected. I will add test when upstream do so. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
