https://bugzilla.redhat.com/show_bug.cgi?id=1869267 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks good now, thanks! - package builds and installs successfully on rawhide - license breakdown documented in the .spec file - includes license texts (upstream source doesn't have them) - latest version is packaged - build and install scriptlets look "good" - Provides and Requires look good (I don't envy working with this messed up upstream project.) Package APPROVED. (The full fedora-review output doesn't add anything useful here.) Though you might want to change the executable permission from 775 to 755 on the tarball creation script: W: strange-permission get-jbosstools.sh 775 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
