https://bugzilla.redhat.com/show_bug.cgi?id=1869270 --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Same here, it's not "safe" to use macros before they are defined. You should move the %global preamble into an order (and place) such that everything is definied when it's used (i.e. move javahl_version definition above its usage in javahl_tag definition, move subclipse_tag definition below Version definition). Possibly also move these two lines from %build into %prep to the rest of the pom.xml file modifications? %pom_remove_plugin ":bnd-maven-plugin" base cmdline javahl svnkit %pom_remove_plugin ":maven-jar-plugin" base cmdline javahl svnkit There's also a lot of dangling symlinks in /usr/share/eclipse/droplets/subclipse/plugins/ that link to various JARs shipped by other packages. Should there be explicit "Requires: foo" for the packages providing the actual JAR files? [list attached below] You also should include the Apache-2.0 license (either from javahl or svnclientadapter) files with %license, and describe the license breakdown above the License tag, with something along the lines of: # EPL-1.0: subclipse # ASL 2.0: javahl and svnclientadapter # CC-BY: ??? License: EPL-1.0 and ASL 2.0 and CC-BY [list of dangling JAR symlinks]: /usr/share/eclipse/droplets/subclipse/plugins/org.tigris.subversion.clientadapter .javahl_1.11.1/lib/javahl.jar /usr/share/java/svn-javahl.jar .svnkit_1.8.12.3/lib/antlr-runtime-3.2.jar /usr/share/java/antlr32/antlr-runtime-3.2.jar .svnkit_1.8.12.3/lib/jna-platform.jar /usr/share/java/jna/jna-platform.jar .svnkit_1.8.12.3/lib/jna.jar /usr/lib/java/jna/jna.jar .svnkit_1.8.12.3/lib/jsch.agentproxy.connector-factory.jar /usr/share/java/jsch-agent-proxy/jsch.agentproxy.connector-factory.jar .svnkit_1.8.12.3/lib/jsch.agentproxy.core.jar /usr/share/java/jsch-agent-proxy/jsch.agentproxy.core.jar .svnkit_1.8.12.3/lib/jsch.agentproxy.pageant.jar /usr/share/java/jsch-agent-proxy/jsch.agentproxy.pageant.jar .svnkit_1.8.12.3/lib/jsch.agentproxy.sshagent.jar /usr/share/java/jsch-agent-proxy/jsch.agentproxy.sshagent.jar .svnkit_1.8.12.3/lib/jsch.agentproxy.svnkit-trilead-ssh2.jar /usr/share/java/jsch-agent-proxy/jsch.agentproxy.svnkit-trilead-ssh2.jar .svnkit_1.8.12.3/lib/jsch.agentproxy.usocket-jna.jar /usr/share/java/jsch-agent-proxy/jsch.agentproxy.usocket-jna.jar .svnkit_1.8.12.3/lib/jsch.agentproxy.usocket-nc.jar /usr/share/java/jsch-agent-proxy/jsch.agentproxy.usocket-nc.jar .svnkit_1.8.12.3/lib/sequence-library.jar /usr/share/java/sequence-library/sequence-library.jar .svnkit_1.8.12.3/lib/sqljet.jar /usr/share/java/sqljet.jar .svnkit_1.8.12.3/lib/svnkit-javahl16.jar /usr/lib/java/svnkit/svnkit-javahl16.jar .svnkit_1.8.12.3/lib/svnkit.jar /usr/share/java/svnkit/svnkit.jar .svnkit_1.8.12.3/lib/trilead-ssh2.jar /usr/share/java/trilead-ssh2.jar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
