https://bugzilla.redhat.com/show_bug.cgi?id=1869267 --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- One small issue: Do not use %{version} before it's defined. Either move "%global gittag %{version}" between URL and Source0 (here %version is defined and it's before the first usage of the macro), or drop the macro entirely and replace its usages with plain "%{version}" if you're not expecting that the tag format will change in the future. The package is a bit weird since it only uses one module from a bigger package, but it looks fine. There's just the fact that I can't seem to figure out the License of the code. The file that's marked with %license is rather unhelpful, and there's no NOTICE or LICENSE or COPYING files anywhere ... https://github.com/jbosstools/jbosstools-base/blob/master/foundation/features/org.jboss.tools.foundation.license.feature/license.html Can you add a license breakdown please? And I think for ASL 2.0, you'll need to include the text of the license as well (as is done in other Apache-2.0 Java packages). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
