[Bug 1869107] Review Request: purple-mm-sms - A libpurple plugin for sending and receiving SMS via ModemManager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1869107

Artur Iwicki <fedora@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora@xxxxxxxxxx



--- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> ---
> %global debug_package %{nil}
This is typically a red flag. We *want* debuginfo in Fedora and omitting it is
rather uncommon.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/#_missing_debuginfo_packages

>%build
>make %{?_smp_mflags}
1. Add "%set_build_flags" before the make call. This will set up
CFLAGS/CXXFLAGS/LDFLAGS appropriately. Among others, it should enable debuginfo
generation, fixing the issue above.
2. Replace "make %{?_smp_mflags}" with "%make_build".

>Summary:        A libpurple plugin for sending and receiving SMS via Modemmanager
The ModemManager package in Fedora writes the name like that - "ModemManager",
with a capital M for "manager". Please do the same.
https://src.fedoraproject.org/rpms/ModemManager/blob/master/f/ModemManager.spec


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux