https://bugzilla.redhat.com/show_bug.cgi?id=1869128 --- Comment #1 from Bob Hepple <bob.hepple@xxxxxxxxx> --- *** The online help->License indicates "The writing in the background of the word definitions is licensed under CC BY-NC-SA 4.0." I think this should be mentioned in License: and %license *** Please remove '.' from the end of the Summary: line *** Please use desktop-file-install: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. eg something like: BuildRequires: desktop-file-utils ... desktop-file-install \ --dir %{buildroot}%{_datadir}/applications \ --remove-category Application \ %{name}.desktop ... --add-category/--remove-category as appropriate for ilopona - see 'man desktop-file-install' *** Please validate appdata.xml file https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData: The AppData files MUST correctly validate using appstream-util validate-relax eg. something like this: BuildRequires: libappstream-glib ... %check (or %install) appstream-util validate-relax --nonet %{_metainfodir}/*.appdata.xml ... note the use of %{_metainfodir} (which can also be used in %files) *** Minor bugaboos: optional: $ rpmlint /home/bhepple/rpmbuild/RPMS/x86_64/ilopona-1.0.0-1.fc31.x86_64.rpm ilopona.x86_64: W: description-shorter-than-summary ilopona.x86_64: W: no-documentation ilopona.x86_64: W: no-manual-page-for-binary com.github.Appadeia.ilopona -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
