https://bugzilla.redhat.com/show_bug.cgi?id=1862625 --- Comment #2 from Fabio Valentini <decathorpe@xxxxxxxxx> --- - latest version is packaged - MIT license is correct - package builds and installs successfully - package conforms to OCaml Packaging Guidelines Please adapt the BuildRequires: (foo and bar) to (foo with bar), as mentioned in the other Review Request. The only thing I'm curious about is the 17.4 MB (?) ppx.exe file that's included in the main package. What is it? .exe files are not mentioned in the OCaml Packaging Guidelines. It also looks unreasonably large compared to the size of the source files. (Curiously, despite building this package with "--enablerepo local" for it to pick up the fresh dependencies, the 555 permission issue isn't present.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
