https://bugzilla.redhat.com/show_bug.cgi?id=1867587 Zdenek Dohnal <zdohnal@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(andymenderunix@gm | |ail.com) --- Comment #2 from Zdenek Dohnal <zdohnal@xxxxxxxxxx> --- (In reply to Andy Mender from comment #1) > Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49103238 > > > # dns-sd support for register/sharing devices > > BuildRequires: avahi-devel >= 0.7 > > # uses CUPS API for arrays, options, rastering, HTTP, IPP support > > BuildRequires: cups-devel >= 2.2.0 > > [...] > > # PNG printing support > > BuildRequires: libpng-devel >= 1.6.0 > > # USB printing support > > BuildRequires: libusb-devel >= 1.0 > > Can you check whether these lines can be replaced with their > "pkgconfig(foo)" equivalents? > > All else seems clean. Full review matrix below: > Using pkconfig for BuildRequires isn't mandatory, though I updated spec to reflect it (only cups doesn't ship .pc file on purpose). Please see the updated links, thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
