[Bug 1862619] Review Request: ocaml-ppx-here - Expands [@here] into its location

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1862619



--- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> ---
Thank you for the review, Ankur!  The next time you have a package that needs a
review, let me know.

(In reply to Ankur Sinha (FranciscoD) from comment #2)
> [?]: Final provides and requires are sane (see attachments).
> ^ Both the devel and non-devel packages provide these. Is that OK? (What will
> dnf choose if one simply tries to install ocaml(Ppx_here)?)
>     ocaml(Ppx_here)
>     ocaml(Ppx_here_expander)
>     ocaml(Ppx_here_lib)

If I rebuild other OCaml packages, already in Fedora, in Rawhide then I see the
same thing happen.  The -devel package contains the same Provides as the main
package.  I don't know what has changed to cause this.  Richard, if you are
reading this, is this expected?

> One from rpmlint:
> 
> ocaml-ppx-here-devel.x86_64: E: zero-length
> /usr/lib64/ocaml/ppx_here/ppx_here.mli
> ^
> I think this is OK, but please do re-check

Upstream provides a zero-byte file, because this package doesn't provide a
library, but rather a syntax extension, so the library interface file doesn't
need any contents.  Whether we need to package it at all is the question.  I
don't know the answer, but will try to find out.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux