[Bug 1111691] Review Request: qore - multithreaded programming/scripting language

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1111691



--- Comment #48 from David Nichols <david@xxxxxxxx> ---
(In reply to Andy Mender from comment #47)
> > %package devel
> > Requires: libqore%{?_isa} = %{version}-%{release}
> > Recommends: %{name} = %{version}
> 
> Hmm in the spec file I see the following:
> %package devel
> Summary: The header files needed to compile programs using the qore library
> Requires: libqore%{?_isa} = %{version}-%{release}
> Recommends: %{name}%{?_isa} = %{version}

oops I think I added that back because it is an arch-specific package, and I
assumed that I should only remove it for the noarch packages.  Should I remove
it then here too?

> I'm a little bothered by the mismatch in the source archive sizes as shown
> by fedora-review:
> > https://github.com/qorelanguage/qore/releases/download/release-0.9.4.6/qore-0.9.4.6.tar.bz2 :
> >   CHECKSUM(SHA256) this package     : 6afbc3128bd0d67e81b736f167b1b1c710966f8fb48bd7ecb3f9608ea5a61220
> >   CHECKSUM(SHA256) upstream package : 852141f7b3e1c6fdbc72fafa71e6b624a3963fa5d29de5d1b638098a8bef579a
> 
> I checked myself and the archive inside the SRPM indeed has a different size
> than the one downloaded from GitHub. Could you maybe try switching to the
> tar.gz source tarball instead?
> https://github.com/qorelanguage/qore/archive/release-0.9.4.6.tar.gz
> You would need to modify the URL line a bit.

yes, it's true, the spec file was updated after the release due to this
process.  In the actual release I will have the final spec file once all issues
are resolved.  I believe we are very close now.

Then I can make a new release of Qore with the updated spec file so that the
file match exactly I hope.

I hope that I can get them to match with bz2 due to the space difference.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux