[Bug 1856005] Review Request: DMTCP - (Distributed MultiThreaded Checkpointing)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1856005



--- Comment #8 from Dave Love <dave.love@xxxxxxxxxxxxxxxx> ---
As I looked at it, and it may save Orion saying the same if I'm not putting
words in his mouth:

I saw the tests are still not being run -- see the log.  I think you need to do
something, either fixing it up for python3 or dropping %check, which is
confusing if it never works.  For some packages fixing up tests might not be so
important, but this seems to me like the sort of intricate application for
which they would be.  (Fedora can give you an early warning about impending
breakage due to changes in linux, libc, etc., though I don't know how sensitive
dmtcp is to those.)

Also, rpmlint still complains about the %dir in %files, though I think it's
harmless.  You only need %dir if you're installing into a directory which isn't
owned by a package that's guaranteed to be installed; pkgconfig or cmake files
are common examples.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux