Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: SDL_sound - Library handling decoding of several popular sound file formats Alias: SDL_sound https://bugzilla.redhat.com/show_bug.cgi?id=355811 chris.stone@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From chris.stone@xxxxxxxxx 2007-10-28 17:32 EST ------- ==== REVIEW CHECKLIST ==== - rpmlint output: SDL_sound.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libSDL_sound-1.0.so.1.0.0 /lib64/libpthread.so.0 SDL_sound.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libSDL_sound-1.0.so.1.0.0 /lib64/libdl.so.2 SDL_sound.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libSDL_sound-1.0.so.1.0.0 /usr/lib64/libvorbis.so.0 These are okay, see comment #2 - package named according to package naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package license meets license guidelines - license matches actual license - license included in %doc - spec written in American english - spec file legible - source matches upstream $ diff -ur SDL_sound-1.0.1 ../SOURCES/SDL_sound-1.0.1 <no output> - package successfully compiles and builds on F-7 x86_64 - all build dependencies listed in BR - no locales - proper use of ldconfig - package not relocatable - package owns all directories it creates - no duplicates in %files - file permissions set properly - contains proper %clean - macro usage consistent - contains code - no large documentation files - files in %doc do not affect runtime - header files in devel subpackage - no static libraries - no pkgconfig files - library files without suffix in devel subpackage - devel package requires base package - no libtool archives - not a GUI application - package does not own files or directories owned by other packages - buildroot removed at beginning of %install - all filenames are UTF-8 *** APPROVED *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review