https://bugzilla.redhat.com/show_bug.cgi?id=1867321 --- Comment #3 from Igor Raits <igor.raits@xxxxxxxxx> --- New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ansible-netcommon.spec New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/ansible-collection-ansible-netcommon-1.1.2-1.fc33.src.rpm --- Comment #3 from Igor Raits <igor.raits@xxxxxxxxx> --- Hi Andy, Thank you for review! For sure ansible-collections-netbox-netbox is my package and I am creator of all those packaging-related macros for Ansible :) > licensecheck reports extra licenses: I somehow did not notice this, I've fixed it in spec and also opened issue in upstream https://github.com/ansible-collections/ansible.netcommon/issues/116. > Is the "python3-rpm-macros" package not needed by the netcommon Ansible module? No, it was needed there only for %{python3_version} macro that is used in Requires. > I noticed that ansible-collection-netbox-netbox in addition removes the integration tests and does some sed cleanup magic: Yeah, probably we should do same, fixed. > I somehow don't think Ansible uses these internally, but I might be wrong. If these are not actually a part of the package, they should be removed. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
