https://bugzilla.redhat.com/show_bug.cgi?id=1859414 --- Comment #6 from Vít Ondruch <vondruch@xxxxxxxxxx> --- And again. What is going on with my browser or !@!@#!@#@!!@# * Keep the default generated BRs together: - It would be nice to keep these together: ~~~ BuildRequires: ruby(release) BuildRequires: rubygems-devel BuildRequires: ruby >= 2.5.0 ~~~ - Mixing rubygems-devel in between other requires for instance does not make the review/maintenance easier. * Circular dependency with rubygem-rails - I think that using `rails` gem on various places is shortcut which brings its own issues. I think it would be better to list all the dependencies excluding `rails` itself. * Keep the original tests in place - I prefer to keep the expanded tests in place and copy them to the location they needs to be. But it might be confusing either way. * Simpler test execution - There is too much boilerplate in the `%check` section. I think this would be enough: ~~~ ... snip ... # Let's keep Requires and BuildRequires sorted alphabeticaly BuildRequires: rubygem(actionmailer) = %{version} BuildRequires: rubygem(activestorage) = %{version} BuildRequires: rubygem(bundler) BuildRequires: rubygem(railties) = %{version} BuildRequires: rubygem(sprockets-rails) BuildRequires: rubygem(sqlite3) BuildRequires: rubygem(webmock) ... snip ... %check pushd .%{gem_instdir} ln -s %{_builddir}/tools .. cp -a %{_builddir}/test . export BUNDLE_GEMFILE=${PWD}/Gemfile # At least one dependency less. sed -i '/byebug/ s/^/#/' test/test_helper.rb cat > $BUNDLE_GEMFILE <<EOF gem "railties" gem "actionmailer" gem "activestorage" gem "sprockets-rails" gem "sqlite3" gem "webmock" EOF ruby -rbundler -Itest -e 'Dir.glob "./test/**/*_test.rb", &method(:require)' popd ... snip ... ~~~ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
