[Bug 1859414] Review Request: rubygem-actionmailbox - Email composition and delivery framework (part of Rails)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1859414



--- Comment #4 from Vít Ondruch <vondruch@xxxxxxxxxx> ---
* Never release available upstream
  - actionmailbox 6.0.3.2 is available upstream already. But I guess you want
to keep this in sync with the rest of the RoR, so no big deal ATM.

* Summary and description
  - The summary and description differs from the upstream versions, is that
intentional?

* tests and tools in separate archives
  - What is the reason? Wouldn't it be enough to keep them in one archive?
  - Also, while minor nit, there is probably missing '/' in the command for
tests.

* Missing space after `Requires:`
  - There is missing space in `-doc` subpackage:

~~~
Requires:%{name} = %{version}-%{release}
~~~

* Keep the default generated BRs together


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux