[Bug 1861440] Review Request: rig - system event monitoring and data collection utility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1861440



--- Comment #10 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
> I am curious as to why a name conflict from an external source is a blocker.

It isn't a blocker. It was merely a strong suggestion. As an user, when I do
`pip list` and I see a package listed I suppose it is the same software as the
package I get when I `pip install` it.

Consider this:

    $ sudo dnf install rig
    $ pip install --user rig
    Requirement already satisfied: rig in /usr/lib/python3.9/site-packages
(1.0)
    Requirement already satisfied: psutil in /usr/lib64/python3.9/site-packages
(from rig) (5.7.2)
    Requirement already satisfied: systemd-python in
/usr/lib64/python3.9/site-packages (from rig) (234)


I also suggest the following:

Since https://github.com/TurboTurtle/rig is the upstream repo, it is confusing
that the tarballs not only come from a totally different place, but also
contain not yet pushed changes. In the future, I strongly suggest tagging in
git and fetching tarballs from GitHub directly, for integrity:

    Url:        https://github.com/TurboTurtle/rig
    Source0:    %{url}/archive/%{version}/%{name}-%{version}.tar.gz

(Assuming the tag is identical to version.)


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux