https://bugzilla.redhat.com/show_bug.cgi?id=1861440 --- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Jake Hunsaker from comment #2) > Whoops, sorry about that. Here's the raw spec: > https://raw.githubusercontent.com/TurboTurtle/rig/master/rig.spec > > If you'd prefer I can copy that over to the same location as the srpm. It doesn't really matter where it is located, but please always post the links in this form (for automated downloads): Spec URL: https://raw.githubusercontent.com/TurboTurtle/rig/master/rig.spec SRPM URL: https://people.redhat.com/jhunsake/rig/rig-1.0-1.src.rpm Spec sanity: > Summary: Monitor a system for events and trigger specific actions > Name: rig Consider putting the name first for better readability. Consider aligning the values with spaces like this: Name: rig Summary: Monitor a system for events and trigger specific actions > Release: 1 This is missing the dist tag, see https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ > Source0: http://people.redhat.com/jhunsake/rig/%{name}-%{version}.tar.gz Please use HTTPS. > Requires: python3 This is not be required. It will be autogenerated. > Requires: python3-psutil > Requires: python3-systemd This should not be required. It should be autogenerated from upstream metadata (but it is missing there). > %check > %{__python3} setup.py test Please, use %{python3} over %{__python3}. > %{python3_sitelib}/* This is not discouraged, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include > %license LICENSE Please also add %doc README.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
