https://bugzilla.redhat.com/show_bug.cgi?id=1862460 --- Comment #2 from Matej Grabovsky <mgrabovs@xxxxxxxxxx> --- Thanks for the review, Andy. See below for links to updated spec file and SRPM. (In reply to Andy Mender from comment #1) > Is both a %modname and a %srcname required? I've seen only %srcname in > Python package SPECs. I've removed %modname and kept %srcname only. > You can probably use the %{expand:} macro like so: > %global _description %{expand: > A collection of cache libraries with a common API. > Extracted from Werkzeug.} > > That way you don't have to add backslashes. I found the description to be short enough to bear two backslashes previously, but now I've rewritten it with the macro. > Does the package have any tests worth adding to the %check phase? Unfortunately, it does not. There were some tests in the original Werkzeug, but they were not migrated with the rest of the code. Spec URL: https://copr-be.cloud.fedoraproject.org/results/mgrabovs/cachelib/fedora-rawhide-x86_64/01591433-python-cachelib/python-cachelib.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mgrabovs/cachelib/fedora-rawhide-x86_64/01591433-python-cachelib/python-cachelib-0.1.1-1.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
