https://bugzilla.redhat.com/show_bug.cgi?id=1376511 --- Comment #13 from Stuart Campbell <stuart@xxxxxxxxxxxxxxxxx> --- Thank you very much for the review and helpful comments. - I have used the %{version} macro - Changed the BuildRequires to use pkgconfig where I can (HDF4/5 do not seem to have .pc files) - None of the CMake generated files are useful to ship - this can be changed upstream and then should be included in the package. - Added the license file and (hopefully) made it clear for the nxdir tool being MIT licensed. - removed ldconfig lines. I think there are changes that can be made upstream to clean up the package longer term, which I will try and get included in the next upstream patch release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
