https://bugzilla.redhat.com/show_bug.cgi?id=1859627 --- Comment #8 from Austin Chang <austin880625@xxxxxxxxx> --- (In reply to Andy Mender from comment #7) Sorry for the late response, but I fixed some of the mentioned issues, and still need to check several things: > > %prep > > %setup -q -c -n %{name} > > chmod 644 %{SOURCE0} > > Is this needed to avoid permission issues during the build? rpmlint shows "weird permission" warning at that time and I fixed by this, but it disappeared in later builds. I have deleted now. > > > CFLAGS="$RPM_OPT_FLAGS" ../gdb-%{version}/configure --prefix=%{_prefix} \ > > --libdir=%{_libdir} --mandir=%{_mandir} --infodir=%{_infodir} \ > > --datarootdir=%{gdb_datarootdir} --disable-rpath \ > > --target=%{target} --disable-nls --disable-werror --without-python --without-doc --with-xml --with-expat > > - You can replace $RPM_OPT_FLAGS with the %{optflags} macro. > - I'm not sure about the current "--prefix" setting, since gdb is > theoretically a part of GCC and the prefix should include the target as well > ("--prefix=%{_prefix}/%{target}"). The point here is to avoid invading > directories of the main on-target GCC package. In this way won't I need to copy the needed file from the specified prefix to placed like %{_bindir} in the %install section for it to reside in correct path? If the files to be installed has been listed explicitly in the %files section, how would this option "invade" other normal GCC packages? > > %{_bindir}/%{target}-* > > This should be more specific to your binaries. Based on the mandir entries, > you should have lines like these: > %{_bindir}/%{target}-gdb > %{_bindir}/%{target}-gdbserver > %{_bindir}/%{target}-gdb-add-index > %{_bindir}/%{target}-gdbinit I have changed this into the explicit list, the actual binaries are: %{_bindir}/%{target}-gdb %{_bindir}/%{target}-gdb-add-index %{_bindir}/%{target}-run > > %files devel > > %{_includedir}/gdb/jit-reader.h > > This is quite risky, because the regular gdb package also installs this > header file. Not sure how/whether they differ, but you would need to at > least make your package own the /usr/include/gdb dir. To me that doesn't > sound like a good idea. I'm not sure about the right way to deal with it. Is there a standard(or distribution-independent) path to place arch-specific header files when the package itself doesn't have a safe default path? I have only seen similar things in /usr/lib like placing object files in directories like x86_64-linux-gnu. But they still create possibly conflicting symlinks in /usr/lib . I also haven't learned about how to do this correctly for header files(maybe there is an config options like --libdir ?) As I personally don't use it, is it OK not to install it and remove the whole devel subpackage(which includes only this file)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
