https://bugzilla.redhat.com/show_bug.cgi?id=1861435 --- Comment #3 from Lumír Balhar <lbalhar@xxxxxxxxxx> --- Now I recall why we use pytest-venv instead of pytest-virtualenv. - pytest-virtualenv has no possibility to upgrade an existing package if it is already in a virtual environment which is very inconvenient because micropipenv works with different versions of pip a lot and pip is always there - pytest-virtualenv fails is you give it a package name with a version ("pip>=9.0,<10.0" for example) (In reply to Miro Hrončok from comment #1) > Spec sanity (all soft suggestions): > > 1. is the %module_name variable any helpful when used just once? Removed. > 2. can the URL be demacronized, so it is easier to copy paste from spec? Done. > 3. is the requirement on python3dist(pytest) not done upstream? have you > queried why? Yes and yes. See https://github.com/mmerickel/pytest-venv/pull/2 > 4. consider "# Remove bundled egg-info" -- it does nothing useful > (usually), the macros work with dist-info Done -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
