https://bugzilla.redhat.com/show_bug.cgi?id=1860012 --- Comment #6 from Andy Mender <andymenderunix@xxxxxxxxx> --- > There are spaces after each semi-colon. I'm not sure what needs fixing here. I meant splitting the initial tags into blocks and tabulating the visually into columns (with spaces) like this: Name: epic5 Version: 2.1.2 Release: 1%{?dist} Summary: Enhanced Programmable ircII Client # contrib/ircman.c is GPL licensed License: BSD and GPL URL: http://www.epicsol.org Source0: http://ftp.epicsol.org/pub/epic/EPIC5-PRODUCTION/%{name}-%{version}.tar.xz BuildRequires: gcc BuildRequires: gdbm-devel BuildRequires: pkgconfig(ncurses) BuildRequires: pkgconfig(openssl) I don't know whether it's mandatory, but it aides readability :). > This is a compiler and the unversioned SO is an internal shared library, so it doesn't make sense to split it out as it's not usable on its own (unlike libgcc). Thanks for clarifying this. I am new to packaging for Fedora and especially to packaging compilers. > - use built binaries in tests > - fix (r)paths to internal shared library > - filter internal shared library from Provides/Requires > - fix build on F31/F32 Nice! I re-ran `fedora-review` and it picked up a couple of new items: [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/binaryen [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/binaryen "%{_libdir}/%{name}/" should be listed in the %files section perhaps? Rpmlint ------- Checking: binaryen-95-3.fc33.x86_64.rpm binaryen-debuginfo-95-3.fc33.x86_64.rpm binaryen-debugsource-95-3.fc33.x86_64.rpm binaryen-95-3.fc33.src.rpm [...] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-as ['$ORIGIN/../lib64/binaryen'] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-ctor-eval ['$ORIGIN/../lib64/binaryen'] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-dis ['$ORIGIN/../lib64/binaryen'] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-emscripten-finalize ['$ORIGIN/../lib64/binaryen'] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-metadce ['$ORIGIN/../lib64/binaryen'] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-opt ['$ORIGIN/../lib64/binaryen'] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-reduce ['$ORIGIN/../lib64/binaryen'] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-shell ['$ORIGIN/../lib64/binaryen'] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm2js ['$ORIGIN/../lib64/binaryen'] binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/binaryen/libbinaryen.so ['$ORIGIN/../lib64/binaryen'] Just double-checking - these come from your RPATH fixes, correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
