[Bug 1811183] Review Request: golang-github-aliyun-cli - Alibaba Cloud CLI

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1811183

Brandon Perkins <bperkins@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(zebob.m@xxxxxxxxx
                   |                            |)



--- Comment #4 from Brandon Perkins <bperkins@xxxxxxxxxx> ---
Spec URL:
https://raw.githubusercontent.com/bdperkin/aliyun/master/SPECS/golang-github-aliyun-cli.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/558/48200558/golang-github-aliyun-cli-3.0.54-2.s20200728git73a3ade.fc33.src.rpm

Changes are not complete, so not requesting fedora-review+ flag yet.

Changes:
- Enable check stage
- Rename godocs in subdirectories
- Remove explicit gzip of man page
- Change gometaabs from define to global
- Update to version 3.0.54 (#1811183)
- Explicitly harden package
- Update to aliyun-openapi-meta to commit
  73a3ade39a109bda00ae3a80585fac98b3f3dd70
- Remove golang(github.com/satori/go.uuid)
  (commit=b2ce2384e17bbe0c6d34077efa39dbab3e09123b) BuildRequires
- Fix man page generation
- Clean changelog

Blocking Issue/Question: Build still fails after my patch:
https://github.com/bdperkin/aliyun/blob/master/SOURCES/aliyun-cli-get-access-key-secret.patch
Output:
=====================================================================================
# github.com/aliyun/aliyun-cli/oss/lib
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/cli_bridge.go:157:12:
undefined: credentials.Configuration
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/cli_bridge.go:160:11:
undefined: credentials.Configuration
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/cli_bridge.go:166:11:
undefined: credentials.Configuration
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/cli_bridge.go:173:11:
undefined: credentials.Configuration
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/cli_bridge.go:183:11:
undefined: credentials.Configuration
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/cli_bridge.go:211:2:
cannot use accessKeyID (type *string) as type string in return argument
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/cli_bridge.go:211:2:
cannot use accessSecret (type *string) as type string in return argument
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/cli_bridge.go:211:2:
cannot use stsToken (type *string) as type string in return argument
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/ecs_role.go:92:10:
cannot use &EcsRoleAK literal (type *EcsRoleAK) as type oss.Credentials in
return argument:
        *EcsRoleAK does not implement oss.Credentials (missing GetAccessKeyID
method)
                have GetAccessKeyId() string
                want GetAccessKeyID() string
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/ecs_role.go:95:9:
cannot use &EcsRoleAK literal (type *EcsRoleAK) as type oss.Credentials in
return argument:
        *EcsRoleAK does not implement oss.Credentials (missing GetAccessKeyID
method)
                have GetAccessKeyId() string
                want GetAccessKeyID() string
../aliyun-openapi-meta-73a3ade39a109bda00ae3a80585fac98b3f3dd70/_build/src/github.com/aliyun/aliyun-cli/oss/lib/ecs_role.go:95:9:
too many errors
=====================================================================================

Thoughts?


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux