https://bugzilla.redhat.com/show_bug.cgi?id=1350884 --- Comment #38 from Brandon Nielsen <nielsenb@xxxxxxxxxxx> --- (In reply to Jonathan Wakely from comment #37) > (In reply to Brandon Nielsen from comment #36) [Snip] > > One final question, do I need to run add a check step? They used to not > > work, but I think they do now. > > I'm not sure what you're referring to, %check steps have always worked as > far as I know. > > It's probably a good idea to add one. Maybe just compile and link a "hello, > world" program as a sanity check. You won't be able to run it of course. That was poorly worded. I used to never be able to get 'make check' to do more than produce a bunch of failures, no matter how I built the upstream sources. It seems to have started working at some point. I'll add the corresponding %check step to the specfile. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
