https://bugzilla.redhat.com/show_bug.cgi?id=1859207 Zdenek Dohnal <zdohnal@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxx --- Comment #8 from Zdenek Dohnal <zdohnal@xxxxxxxxxx> --- (In reply to Artur Iwicki from comment #7) > [!]: Package consistently uses macros (instead of hard-coded directory > names). > In %files, you have: > %dir /etc/sane.d > %config(noreplace) /etc/sane.d/airscan.conf > Use "%{_sysconfdir}" instead of hard-coding "/etc". Ok, I'll fix it. > > > [!]: Latest version is packaged. > The SRPM contained the latest version at the time it was submitted, > but a few days ago a new version, 0.99.11, has been released. > Ok, I'll rebase to the newest version, but I would like to ask you to don't consider this as a blocker. sane-airscan is under rapid development and there can be a new release per week. I usually update my package to the newest version regularly. > > [x]: Packages should try to preserve timestamps of original installed files. > The upstream Makefile does not use the "-p" flag when installing man pages. > I don't think you need to patch this, though it'd be nice to file an issue > or submit a pull request. > If I understand FPG [1] correctly, it is applied only on copying commands used in SPEC file (not in 'make install' itself), or if you download sources. So I would let it be as it is now. [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps > [ ]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /etc/sane.d(sane-backends), > /etc/sane.d/dll.d(sane-backends), /usr/lib64/sane(sane-backends) Those directories are owned by sane-backends, but sane-airscan doesn't need sane-backends to work. > ===== EXTRA items ===== > > Generic: > [!]: Spec file according to URL is the same as in SRPM. I'm not sure what does it mean - I uploaded the srpm which is created by 'fedpkg --release f32 local'. Is it really different? And please assign yourself -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
