https://bugzilla.redhat.com/show_bug.cgi?id=1861435 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity (all soft suggestions): 1. is the %module_name variable any helpful when used just once? 2. can the URL be demacronized, so it is easier to copy paste from spec? 3. is the requirement on python3dist(pytest) not done upstream? have you queried why? 4. consider "# Remove bundled egg-info" -- it does nothing useful (usually), the macros work with dist-info A slightly stronger query: Why is this package packaged? Despite the name, it seem to use virtualenv, not venv, and we already have pytest-virtualenv packaged. pytest-virtualenv has a active looking devlopment, while pytest-venv seem rather upstream dead with only 3 versions released, on the same day in November 2016. I see you've opened https://github.com/mmerickel/pytest-venv/issues/1 which is very friendly of you, however, does pytest-venv have any advantages over pytest-virtualenv? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
