[Bug 1860729] Review Request: wshowkeys - Displays keypresses on screen on supported Wayland compositors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1860729



--- Comment #7 from Bob Hepple <bob.hepple@xxxxxxxxx> ---
I'm an idiot! I forgot to re-apply the patch to the spec file in my rush to get
out the door.

This version silences rpmlint:


        if (setgid(getgid()) != 0) {
                fprintf(stderr, "devmgr: setgid: %s\n", strerror(errno));
                return 1;
        }
        if (setuid(getuid()) != 0) {
                fprintf(stderr, "devmgr: setuid: %s\n", strerror(errno));
                return 1;
        }
        if (setgroups(0, NULL) != -1) {
                fprintf(stderr, "devmgr: failed to drop root\n");
                return 1;
        }
        if (setuid(0) != -1) {
                fprintf(stderr, "devmgr: failed to drop root\n");
                return 1;
        }

Shall I go ahead with release 3.20200727git6388a49 without the patch or include
a patch in release 4... ???

Thanks again and sorry for the confusion.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux