https://bugzilla.redhat.com/show_bug.cgi?id=1860729 --- Comment #2 from Qiyu Yan <yanqiyu01@xxxxxxxxx> --- Since /usr/bin/wshowkeys has setuid flag, things are getting diffficult (otherwise this will be a security risk) What you should do (I think) is - Suggest: Check if the setuid is needed - Must: set %global _hardened_build 1 - Suggest: deal with missing-call-to-setgroups-before-setuid, maybe you need to patch the code And try to make this as safe as possible (maybe set permission to 4711). Suggest part is not so important, but my personal advice... Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package uses hardened build flags if required to. Note: suid files: wshowkeys and not %global _hardened_build See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_compiler_flags ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "NTP License (legal disclaimer)". 12 files have unknown license. Detailed output of licensecheck in /home/yan/review/copr-build-1582100/review-wshowkeys/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: wshowkeys-0-2.20200727git6388a49.fc33.x86_64.rpm wshowkeys-debuginfo-0-2.20200727git6388a49.fc33.x86_64.rpm wshowkeys-debugsource-0-2.20200727git6388a49.fc33.x86_64.rpm wshowkeys-0-2.20200727git6388a49.fc33.src.rpm wshowkeys.x86_64: W: spelling-error %description -l en_US wlr -> war, SLR # That is normal wshowkeys.x86_64: W: spelling-error %description -l en_US eg -> eh, e, g # also fine wshowkeys.x86_64: W: spelling-error %description -l en_US monospace -> mono space, mono-space, aerospace # I think this is normal wshowkeys.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/wshowkeys wshowkeys.x86_64: E: setuid-binary /usr/bin/wshowkeys root 4755 # if setuid is required, we can ignore this wshowkeys.x86_64: E: non-standard-executable-perm /usr/bin/wshowkeys 4755 # also if setuid is required, we can ignore this wshowkeys.x86_64: W: no-manual-page-for-binary wshowkeys wshowkeys.src: W: spelling-error %description -l en_US wlr -> war, SLR wshowkeys.src: W: spelling-error %description -l en_US eg -> eh, e, g wshowkeys.src: W: spelling-error %description -l en_US monospace -> mono space, mono-space, aerospace 4 packages and 0 specfiles checked; 3 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: wshowkeys-debuginfo-0-2.20200727git6388a49.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- (none): E: no installed packages by name wshowkeys-debuginfo (none): E: no installed packages by name wshowkeys 0 packages and 0 specfiles checked; 0 errors, 0 warnings. (none): E: no installed packages by name wshowkeys-debugsource Source checksums ---------------- https://git.sr.ht/~sircmpwn/wshowkeys/archive/6388a49e0f431d6d5fcbd152b8ae4fa8e87884ee.tar.gz#/wshowkeys-6388a49e0f431d6d5fcbd152b8ae4fa8e87884ee.tar.gz : CHECKSUM(SHA256) this package : 8d4c0cee88c2147044bd2ef12948e5d823fc0f016c1e30ea6888553902aff446 CHECKSUM(SHA256) upstream package : 8d4c0cee88c2147044bd2ef12948e5d823fc0f016c1e30ea6888553902aff446 Requires -------- wshowkeys (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcairo.so.2()(64bit) libgobject-2.0.so.0()(64bit) libinput.so.10()(64bit) libinput.so.10(LIBINPUT_0.12.0)(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) librt.so.1()(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libwayland-client.so.0()(64bit) libxkbcommon.so.0()(64bit) libxkbcommon.so.0(V_0.5.0)(64bit) rtld(GNU_HASH) wshowkeys-debuginfo (rpmlib, GLIBC filtered): wshowkeys-debugsource (rpmlib, GLIBC filtered): Provides -------- wshowkeys: wshowkeys wshowkeys(x86-64) wshowkeys-debuginfo: debuginfo(build-id) wshowkeys-debuginfo wshowkeys-debuginfo(x86-64) wshowkeys-debugsource: wshowkeys-debugsource wshowkeys-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review --copr-build 01582100 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Ocaml, PHP, SugarActivity, Perl, Haskell, R, fonts, Python, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
