Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gnuplot https://bugzilla.redhat.com/show_bug.cgi?id=225849 ------- Additional Comments From pertusus@xxxxxxx 2007-10-27 07:06 EST ------- The iconv on fontfile_latex.dem epslatex.dem epslatex.dem fontfile.dem are completly wrong. The encoding is set in these files to latin1, they should be kept as is. Also I don't know what demo.edf is but running iconv on it is certainly wrong, since it looks like there is some binary info in it. You still don't follow the emacs guidelines, since there is a versionned dependency on emacs(bin) required. Also you should certainly use the %define emacs_version %(pkg-config emacs --modversion) %define emacs_lispdir %(pkg-config emacs --variable sitepkglispdir) %define emacs_startdir %(pkg-coonfig emacs --variable sitestartdir) with apropriate buildrequires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review