https://bugzilla.redhat.com/show_bug.cgi?id=1859627 --- Comment #5 from Andy Mender <andymenderunix@xxxxxxxxx> --- After some fiddling, I managed to run `fedora-review` from the COPR build, thanks! > BuildRequires: gmp-devel > BuildRequires: libmpc-devel > %if 0%{?fedora} >= 32 > BuildRequires: pkgconfig(mpfr) > %else > BuildRequires: mpfr-devel > %endif > BuildRequires: pkgconfig(ncurses) > BuildRequires: sed > BuildRequires: texinfo > BuildRequires: pkgconfig(zlib) I would check whether it's possible to replace the "*-devel" lines with "pkgconfig(foo)" like you did in the other cases. > cd binutils > %make_install > cd - > cd gcc > PATH=$PWD/../bin:$PATH > %make_install > # Reset the path > PATH=%{base_path} > cd - > cd gdb > %make_install > cd - Add the "-p" flag to %make_install to preserve timestamps. Quite a bit of clean-up needs to be done still, sorry :(. There is a load of header files, libtools and static objects which shouldn't be there. The full review matrix is below (I included the full review + rpmlint in attached file): Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. **Lots of leftover header files in subdirs of /usr/msp430-elf** See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - Package does not contain any libtool archives (.la) Note: msp430-elf-gcc : /usr/msp430-elf/libexec/gcc/msp430-elf/9.2.0/liblto_plugin.la See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries - Package uses either %{buildroot} or $RPM_BUILD_ROOT Note: Using both %{buildroot} and $RPM_BUILD_ROOT See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file copying.c is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: msp430-elf-gcc, msp430-elf-gcc-c++. Illegal package name: msp430-elf-gcc, msp430-elf-gcc-c++. Does not provide -static: msp430-elf-gcc, msp430-elf-gcc-c++. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [?]: Package contains no static executables. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Provides: bundled(gnulib) in place as required. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock/fedora- rawhide-x86_64/root/builddir/build/BUILD/msp430-elf-toolchain' returned non-zero exit status 2. Review: Ran licensecheck manually. A lot of files are BSD licensed! This should be included in the "License:" block as "GPL and BSD" [!]: License file installed when any subpackage combination is installed. Review: all main packages should include the license file. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/msp430-elf/libexec/gcc/msp430-elf/9.2.0, /usr/msp430-elf/lib/gcc/msp430-elf/9.2.0, /usr/msp430-elf/lib, /usr/msp430-elf/libexec/gcc/msp430-elf, /usr/msp430-elf/lib/gcc/msp430-elf, /usr/msp430-elf/libexec/gcc, /usr/msp430-elf/msp430-elf/lib, /usr/msp430-elf/bin, /usr/msp430-elf/lib/gcc, /usr/msp430-elf/msp430-elf, /usr/msp430-elf, /usr/msp430-elf/libexec, /usr/msp430-elf/msp430-elf/include [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/msp430-elf/msp430-elf/lib/large/full-memory-range, /usr/msp430-elf/libexec/gcc/msp430-elf, /usr/msp430-elf/libexec/gcc, /usr/msp430-elf/msp430-elf/lib/large/exceptions, /usr/msp430-elf/lib/gcc, /usr/msp430-elf, /usr/msp430-elf/msp430-elf/lib/exceptions, /usr/msp430-elf/msp430-elf/lib/large/full-memory-range/exceptions, /usr/msp430-elf/msp430-elf/include, /usr/msp430-elf/msp430-elf/lib/430/exceptions, /usr/msp430-elf/libexec/gcc/msp430-elf/9.2.0, /usr/msp430-elf/msp430-elf/lib/430, /usr/msp430-elf/lib/gcc/msp430-elf/9.2.0, /usr/msp430-elf/lib, /usr/msp430-elf/lib/gcc/msp430-elf, /usr/msp430-elf/bin, /usr/msp430-elf/msp430-elf/lib, /usr/msp430-elf/msp430-elf/lib/large, /usr/msp430-elf/msp430-elf, /usr/msp430-elf/libexec [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. Macros in changelog are not allowed. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [!]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package does not own files or directories owned by other packages. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://software- dl.ti.com/msp430/msp430_public_sw/mcu/msp430/MSPGCC/9_2_0_0/export/msp430-gcc-9.2.0.50-source- full.tar.bz2 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ NOt [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in msp430-elf-gcc , msp430-elf-gcc-c++ , msp430-elf-gdb , msp430-elf- binutils Review: it's a good idea to include this. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define __os_install_post . ./os_install_post [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. **Full rpmlint in attached file** Unversioned so-files -------------------- msp430-elf-gcc: /usr/msp430-elf/lib/gcc/msp430-elf/9.2.0/plugin/libcc1plugin.so msp430-elf-gcc: /usr/msp430-elf/lib/gcc/msp430-elf/9.2.0/plugin/libcp1plugin.so msp430-elf-gcc: /usr/msp430-elf/libexec/gcc/msp430-elf/9.2.0/liblto_plugin.so Requires -------- msp430-elf-gcc (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcc1plugin.so.0()(64bit) libcp1plugin.so.0()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libgmp.so.10()(64bit) liblto_plugin.so.0()(64bit) libm.so.6()(64bit) libmpc.so.3()(64bit) libmpfr.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) msp430-elf-gcc-c++ (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) msp430-elf-gdb (rpmlib, GLIBC filtered): /usr/bin/sh libc.so.6()(64bit) libdl.so.2()(64bit) libexpat.so.1()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libncursesw.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtinfo.so.6()(64bit) rtld(GNU_HASH) msp430-elf-binutils (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) msp430-elf-toolchain-debuginfo (rpmlib, GLIBC filtered): msp430-elf-toolchain-debugsource (rpmlib, GLIBC filtered): Provides -------- msp430-elf-gcc: bundled(gnulib) libcc1plugin.so.0()(64bit) libcp1plugin.so.0()(64bit) liblto_plugin.so.0()(64bit) msp430-elf-gcc msp430-elf-gcc(x86-64) msp430-elf-gcc-c++: msp430-elf-gcc-c++ msp430-elf-gcc-c++(x86-64) msp430-elf-gdb: msp430-elf-gdb msp430-elf-gdb(x86-64) msp430-elf-binutils: msp430-elf-binutils msp430-elf-binutils(x86-64) msp430-elf-toolchain-debuginfo: msp430-elf-toolchain-debuginfo msp430-elf-toolchain-debuginfo(x86-64) msp430-elf-toolchain-debugsource: msp430-elf-toolchain-debugsource msp430-elf-toolchain-debugsource(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
