https://bugzilla.redhat.com/show_bug.cgi?id=1853081 --- Comment #4 from Spencer Lingard <spencer@xxxxxxxxxxxx> --- New version for review. Spec URL: https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bfscripts/fedora-rawhide-aarch64/01575325-mlxbf-bfscripts/mlxbf-bfscripts.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/slingard/mlxbf-bfscripts/fedora-rawhide-aarch64/01575325-mlxbf-bfscripts/mlxbf-bfscripts-3.0.0~beta1-3.fc33.src.rpm Scratch Koji URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=47787034 (In reply to Artur Iwicki from comment #3) > >Source: mlxbf-bfscripts.tar.gz > Ideally this should be a downloadable URL. Are you using the "3.0.beta1" git > tag? Then you could use > "https://github.com/Mellanox/bfscripts/archive/3.0.beta1/bfscripts-3.0.beta1. > tar.gz" here. The spec file and SRPM are generated by rpkg-util. I put a comment here that shows how to create the source files needed. > >%{__install} bfbootmgr %{installdir} > >%{__install} man/bfbootmgr.8 %{man8dir} > >... > 1. Macro forms of system executables are discouraged. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros Done. > 2. Use the "-p" flag to preserve timestamps. > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps Done. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
