https://bugzilla.redhat.com/show_bug.cgi?id=1636111 Lewis <anesa.lewis@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anesa.lewis@xxxxxxxxx --- Comment #43 from Lewis <anesa.lewis@xxxxxxxxx> --- Hi, here is my review, but keep in mind, I'm new : This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/glyr See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [X]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. License file is missing : find glyr-1.0.10 -iname *lic* glyr-1.0.10/lib/CMakeFiles/glyr.dir/intern/photos/flickr.c.o glyr-1.0.10/lib/jsmn/LICENSE glyr-1.0.10/lib/intern/photos/flickr.c glyr-1.0.10/src/utils/license.py please use this one : https://www.gnu.org/licenses/gpl-3.0.txt [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU Lesser General Public License (v3)", "GNU Lesser General Public License (v3 or later)", "Expat License", "*No copyright* Expat License". 34 files have unknown license. Detailed output of licensecheck in no license file [!]: License file installed when any subpackage combination is installed. no license file [X]: Package must own all directories that it creates. Note: Directories without known owners: /usr/include/glyr [!]: %build honors applicable compiler flags or justifies otherwise. Please use : %build %set_build_flags %{cmake} %make_build not sure if really applicable with cmake but I could suggest to run cmake in %prep section to prepare it to build [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [X]: Sources contain only permissible code or content. at maximum, grep gives Pussycat Dolls 3 time [-]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [X]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). Yes but please use asterisk wildcards for naming : - %{_includedir}/%{name}/glyr.h - %{_includedir}/%{name}/types.h - %{_includedir}/%{name}/cache.h - %{_includedir}/%{name}/misc.h - %{_includedir}/%{name}/config.h - %{_includedir}/%{name}/testing.h + %{_includedir}/%{name}/*.h [X]: Package is named according to the Package Naming Guidelines. done but why not naming it glyros as you firstly wanted? [X]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. can't get a clue here [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [?]: Requires correct, justified where necessary. sure perl-devel and gtk2-devel are not required? [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Useful -debuginfo package or justification otherwise. [X]: Package is not known to require an ExcludeArch tag. [X]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. yes and in a separate -doc subpackage [X]: Package complies to the Packaging Guidelines As far as I investigated, but I'm still a newbie [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Specific : ===== SHOULD items ===== Generic: [X]: Buildroot is not present Note: Buildroot: present but not needed Due to my environement [X]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required So may be deleted [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. no license file [?]: Final provides and requires are sane (see attachments). Thew look sane [X]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libglyr , libglyr-devel [X]: Package functions as described. looks like yes... [?]: Latest version is packaged. They may have updated it [-]: Package does not include license text files separate from upstream. no license file [X]: Scriptlets must be sane, if used. [X]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. %check missing but that's not a must item [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. Done with mock [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: glyr-1.0.10-1.x86_64.rpm libglyr-1.0.10-1.x86_64.rpm libglyr-devel-1.0.10-1.x86_64.rpm glyr-1.0.10-1.src.rpm glyr.x86_64: E: explicit-lib-dependency libcurl glyr.x86_64: W: spelling-error Summary(en_US) eninge -> engine, genning, meninges glyr.x86_64: W: spelling-error Summary(en_US) musicrelated -> music related, music-related, matriculated glyr.x86_64: W: name-repeated-in-summary C Glyr glyr.x86_64: W: spelling-error %description -l en_US searcheninge -> searching glyr.x86_64: W: spelling-error %description -l en_US musicrelated -> music related, music-related, matriculated glyr.x86_64: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment glyr.x86_64: W: spelling-error %description -l en_US musicplayer -> music player, music-player, musicality glyr.x86_64: W: spelling-error %description -l en_US bandphotos -> band photos, band-photos, photostats glyr.x86_64: W: spelling-error %description -l en_US tracklists -> track lists, track-lists, blacklists glyr.x86_64: W: spelling-error %description -l en_US wikipedia -> Wikipedia, pediatric glyr.x86_64: E: no-changelogname-tag glyr.x86_64: W: no-manual-page-for-binary glyrc libglyr.x86_64: W: spelling-error Summary(en_US) glyr -> glyph libglyr.x86_64: W: summary-not-capitalized C glyr library libglyr.x86_64: W: spelling-error %description -l en_US glyr -> glyph libglyr.x86_64: E: no-changelogname-tag libglyr.x86_64: W: no-documentation libglyr-devel.x86_64: E: no-changelogname-tag libglyr-devel.x86_64: W: no-documentation glyr.src: W: spelling-error Summary(en_US) eninge -> engine, genning, meninges glyr.src: W: spelling-error Summary(en_US) musicrelated -> music related, music-related, matriculated glyr.src: W: name-repeated-in-summary C Glyr glyr.src: W: spelling-error %description -l en_US searcheninge -> searching glyr.src: W: spelling-error %description -l en_US musicrelated -> music related, music-related, matriculated glyr.src: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment glyr.src: W: spelling-error %description -l en_US musicplayer -> music player, music-player, musicality glyr.src: W: spelling-error %description -l en_US bandphotos -> band photos, band-photos, photostats glyr.src: W: spelling-error %description -l en_US tracklists -> track lists, track-lists, blacklists glyr.src: W: spelling-error %description -l en_US wikipedia -> Wikipedia, pediatric glyr.src: E: no-changelogname-tag glyr.src: W: invalid-url Source0: glyr-1.0.10.tar.gz 4 packages and 0 specfiles checked; 5 errors, 27 warnings. Rpmlint (installed packages) ---------------------------- warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. libglyr-devel.x86_64: E: no-changelogname-tag libglyr-devel.x86_64: W: invalid-url URL: https://github.com/sahib/glyr <urlopen error [Errno -2] Name or service not known> libglyr-devel.x86_64: W: no-documentation warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. libglyr.x86_64: W: spelling-error Summary(en_US) glyr -> glyph libglyr.x86_64: W: summary-not-capitalized C glyr library libglyr.x86_64: W: spelling-error %description -l en_US glyr -> glyph libglyr.x86_64: E: no-changelogname-tag libglyr.x86_64: W: invalid-url URL: https://github.com/sahib/glyr <urlopen error [Errno -2] Name or service not known> libglyr.x86_64: W: no-documentation warning: Found bdb Packages database while attempting sqlite backend: using bdb backend. glyr.x86_64: E: explicit-lib-dependency libcurl glyr.x86_64: W: spelling-error Summary(en_US) eninge -> engine, genning, meninges glyr.x86_64: W: spelling-error Summary(en_US) musicrelated -> music related, music-related, matriculated glyr.x86_64: W: name-repeated-in-summary C Glyr glyr.x86_64: W: spelling-error %description -l en_US searcheninge -> searching glyr.x86_64: W: spelling-error %description -l en_US musicrelated -> music related, music-related, matriculated glyr.x86_64: W: spelling-error %description -l en_US commandline -> command line, command-line, commandment glyr.x86_64: W: spelling-error %description -l en_US musicplayer -> music player, music-player, musicality glyr.x86_64: W: spelling-error %description -l en_US bandphotos -> band photos, band-photos, photostats glyr.x86_64: W: spelling-error %description -l en_US tracklists -> track lists, track-lists, blacklists glyr.x86_64: W: spelling-error %description -l en_US wikipedia -> Wikipedia, pediatric glyr.x86_64: E: no-changelogname-tag glyr.x86_64: W: invalid-url URL: https://github.com/sahib/glyr <urlopen error [Errno -2] Name or service not known> glyr.x86_64: W: no-manual-page-for-binary glyrc 3 packages and 0 specfiles checked; 4 errors, 19 warnings. Requires -------- glyr (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libcurl libglib-2.0.so.0()(64bit) libglyr libglyr.so.1()(64bit) rtld(GNU_HASH) sqlite libglyr (rpmlib, GLIBC filtered): libc.so.6()(64bit) libcurl.so.4()(64bit) libglib-2.0.so.0()(64bit) libsqlite3.so.0()(64bit) rtld(GNU_HASH) libglyr-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libglyr libglyr.so.1()(64bit) pkgconfig(glib-2.0) pkgconfig(libcurl) pkgconfig(sqlite3) Provides -------- glyr: glyr glyr(x86-64) libglyr: libglyr libglyr(x86-64) libglyr.so.1()(64bit) libglyr-devel: libglyr-devel libglyr-devel(x86-64) pkgconfig(libglyr) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 -n glyr Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: SugarActivity, Java, Perl, PHP, Python, Haskell, Ocaml, fonts, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
