[Bug 1859891] Review Request: python2-dns - DNS toolkit for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1859891



--- Comment #5 from Lumír Balhar <lbalhar@xxxxxxxxxx> ---
> > Patch0:         unicode_label_escapify.patch
> > Patch1:         collections_abc.patch
> > Patch2:         base64.patch
> > Patch3:         switch_to_python_cryptography.patch
> 
> It might be a good idea to shortly explain what do the patches do.
> 
> For example collections_abc.patch and base64.patch seem useless on Python 2.

These two removed.

> Similarly, switch_to_python_cryptography.patch seems like moot because there
> is no python2-cryptography on Fedora 33.

python2-dns has no DNSSEC support but it's still better to depend on
cryptography than cryptodomex.

> 
> > %{python2_sitelib}/%{py_package_name}
> > %{python2_sitelib}/%{pypi_name}-*.egg-info
> 
> Consider adding trailing slashes to assert those are directories.

Done.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux