[Bug 226248] Merge Review: perl-Crypt-SSLeay

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: perl-Crypt-SSLeay


https://bugzilla.redhat.com/show_bug.cgi?id=226248





------- Additional Comments From panemade@xxxxxxxxx  2007-10-26 21:47 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
82264180f5911dce33dbd85e24b1f36b  Crypt-SSLeay-0.57.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
- BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/00-basic......ok
t/01-connect....ok        7/8 skipped: nothing listening on localhost:443
t/02-live.......# config on linux# ssl OpenSSL 0.9.8 in /usr# lib -L/usr/lib
-lssl -lcrypto -lgcc
# inc -I/usr/include/openssl
# cc gcc
ok        1/4 skipped: Network tests disabled
All tests successful, 8 subtests skipped.
Files=3, Tests=24,  1 wallclock secs ( 0.54 cusr +  0.05 csys =  0.59 CPU)
+ Package  perl-Crypt-SSLeay-0.57-2.fc8 ->
  Provides: SSLeay.so perl(Crypt::SSLeay) = 0.57 perl(Crypt::SSLeay::CTX)
perl(Crypt::SSLeay::Conn) perl(Crypt::SSLeay::Err)
perl(Crypt::SSLeay::MainContext) perl(Crypt::SSLeay::X509) perl(Net::SSL) = 2.84
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.3.4) libc.so.6(GLIBC_2.4)
libcrypto.so.6 libssl.so.6 perl(:MODULE_COMPAT_5.8.8) perl(Carp)
perl(Crypt::SSLeay) perl(Crypt::SSLeay::CTX) perl(Crypt::SSLeay::X509)
perl(IO::Socket) perl(MIME::Base64) perl(Socket) perl(strict) perl(vars)
rtld(GNU_HASH)


===> Remove unnecessary BR: pkgconfig.
     Sorry missed that before.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]