https://bugzilla.redhat.com/show_bug.cgi?id=1859207 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx --- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> --- >Source: https://github.com/alexpevzner/%{name}/archive/%{version}.tar.gz 1. You can use %{URL} here to make the line shorter. 2. GitHub allows you to do "archive/%{version}/%{name}-%{version}.tar.gz" - you can get a file containing the repo name, not just the version. >%autosetup -n %{name}-%{version} -S git The "-S git" part is not needed. Package builds fine without it and the resulting executables/libraries are the same. >%make_build CFLAGS="%{optflags}" CPPFLAGS="%{optflags}" LDFLAGS="%{build_ldflags}" You can call the %set_build_flags macro before %make_build, that should setup up CFLAGS/LDFLAGS. >%{_mandir}/man1/airscan-discover.1.gz >%{_mandir}/man5/sane-airscan.5.gz Do not assume that man pages will be gzipped. Use a wildcard that can match any compression method (including no compression at all). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
