[Bug 1858503] Review Request: python-sphinx_ansible_theme - A reusable Ansible Sphinx Theme

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1858503



--- Comment #3 from Andy Mender <andymenderunix@xxxxxxxxx> ---
> Thanks for your feedback, I updated the spec file accordingly and linked the fonts to the ones from fontsawesome/fontawesome-web packages
> (this is the way the python-sphinx_rtd_theme did it).

Looks good :)

`rpmbuild` complaints about absolute symlinks, but since
python-sphinx_rtd_theme does that, I think it's okay (can't think of a better
way):
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/FontAwesome.otf
-> /usr/share/fonts/fontawesome/FontAwesome.otf
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.eot
-> /usr/share/fonts/fontawesome/fontawesome-webfont.eot
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.svg
-> /usr/share/fonts/fontawesome/fontawesome-webfont.svg
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.ttf
-> /usr/share/fonts/fontawesome/fontawesome-webfont.ttf
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff
-> /usr/share/fonts/fontawesome/fontawesome-webfont.woff
warning: absolute symlink:
/usr/lib/python3.8/site-packages/sphinx_ansible_theme/static/fonts/fontawesome-webfont.woff2
-> /usr/share/fonts/fontawesome/fontawesome-webfont.woff2

Could you try building the package in COPR or Koji to see if everything goes
well? When running a local mock build I see that the build process is trying to
access the Internet:
+ sphinx-build-3 docs html
Running Sphinx v2.2.2
making output directory... done
loading intersphinx inventory from https://docs.python.org/2/objects.inv...
loading intersphinx inventory from ../python2.inv...
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://docs.python.org/2/objects.inv' not fetchable due
to <class 'requests.exceptions.ConnectionError'>:
HTTPSConnectionPool(host='docs.python.org', port=443): Max retries exceeded
with url: /2/objects.inv (Caused by
NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at
0x7f8fd1e8e400>: Failed to establish a new connection: [Errno -2] Name or
service not known'))
intersphinx inventory '../python2.inv' not fetchable due to <class
'FileNotFoundError'>: [Errno 2] No such file or directory:
'/builddir/build/BUILD/sphinx_ansible_theme-0.3.1/docs/../python2.inv'
loading intersphinx inventory from ../python3.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'https://docs.python.org/3/objects.inv' not fetchable due
to <class 'requests.exceptions.ConnectionError'>:
HTTPSConnectionPool(host='docs.python.org', port=443): Max retries exceeded
with url: /3/objects.inv (Caused by
NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at
0x7f8fd1e8e580>: Failed to establish a new connection: [Errno -2] Name or
service not known'))
intersphinx inventory '../python3.inv' not fetchable due to <class
'FileNotFoundError'>: [Errno 2] No such file or directory:
'/builddir/build/BUILD/sphinx_ansible_theme-0.3.1/docs/../python3.inv'
loading intersphinx inventory from
http://jinja.palletsprojects.com/objects.inv...
loading intersphinx inventory from ../jinja2.inv...
loading intersphinx inventory from
https://docs.ansible.com/ansible/2.9/objects.inv...
WARNING: failed to reach any of the inventories with the following issues:
intersphinx inventory 'http://jinja.palletsprojects.com/objects.inv' not
fetchable due to <class 'requests.exceptions.ConnectionError'>:
HTTPConnectionPool(host='jinja.palletsprojects.com', port=80): Max retries
exceeded with url: /objects.inv (Caused by
NewConnectionError('<urllib3.connection.HTTPConnection object at
0x7f8fd1e8e0d0>: Failed to establish a new connection: [Errno -2] Name or
service not known'))
intersphinx inventory '../jinja2.inv' not fetchable due to <class
'FileNotFoundError'>: [Errno 2] No such file or directory:
'/builddir/build/BUILD/sphinx_ansible_theme-0.3.1/docs/../jinja2.inv'

It completes "successfully", but if the package ends up being incomplete,
that's also not good.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux