https://bugzilla.redhat.com/show_bug.cgi?id=1858256 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Please detail how you generated the Sources Source0: rpm-git-tag-sort-498f832d-dirty.tar.gz Source1: rpm-git-tag-sort-c-vector-498f832d.tar.gz - make → %make_build - You should set Fedora build flags with %set_build_flags, and make sure that the Makefile respect them (CFLAGS) - make install root=%{buildroot} → Use DESTDIR instead of root in your Makefile, and then use %make_install - Provide a license file and install it with %license in %files. A README.md as %doc would be nice too. %files /usr/bin/rpm-git-tag-sort - Please provide a changelog entry - The version is unsortable: 0.0.git.2.498f832d.dirty.0nub0m and the git hash info should be included in Release not Version. I would use the syntax for a prerelease and GIT snapshot: Version: 0 Release: 0.1.20200717git498f832%{?dist} -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
