[Bug 1853888] Review Request: libLTK - Ladspa v3 ToolKit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1853888



--- Comment #12 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> ---
(In reply to Lewis from comment #11)
> Hi,
> 
> > That's the same thing. The unversioned is a link which goes to the -devel subpackage though. See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
> 
> Ok, I'll keep it as is.
> 
> > Libraries deps are generated automatically. If libunwind is updated with a SONAME bump, your package will need to be recompiled. SONAME bump should be announced by the maintainer one week in advance through the devel mailing list.
> 
> Great to hear!!!
> Admit that one day, in the future, other dev use this package.
>
> I'll have to mail the devel mailing list at least one week before this
> change? Each time my package changes it's SOMANE (e.g. MAJOR part of the version),

Yes, you look for package that depends on yours, warn the devel mailing-list
and the dependent package owner.

> I don't know this mailing list but anyway, I don't plan to change this at
> all.
That ML is recommended but not mandatory. There's a lot of bikeshedding going
on.

> 
> > mock -r fedora-rawhide-x86_64 --resultdir=./my-results /path/to/your.src.rpm
> 
> I'll try it out but that might not change my package, isn't it? I promise
> I'll integrate it, I installed mock and added myself to mock group already.
> 
It doesn't change any thing, it rebuilds your package in a chroot isolated from
your main system and from a minimal installation. Like Koji but on your
computer.

> > The sources should be in the same directory as your SPEC:
> 
> LTK Spec file is in the SPECS folder.
> LTK Tarball containig sources is in SOURCES folder.
> As said in section 4 of
> https://doc.fedora-fr.org/wiki/RPM_:_environnement_de_construction ,
> $HOME/rpmbuild/SOURCES (dossier contenant les sources : archives, patches...)
> $HOME/rpmbuild/SPECS (dossier contenant les fichiers .spec contenant les
> instructions de construction)
TBH I was using this at the beginning but moved on to all fedpkg now.
Doing a local build (with fedpkg local or rpmbuild) can be misleading  because
it will need all deps to be installed in your system, and it can also use a
dependency you have installed but forgot to add to the SPEC. I'm not sure I'm
clear, but your packages could locally build because you have a local
dependency installed, but not work in Mock/Koji because you have forgotten to
add it to your SPEC. Mock will start building from a bare system so any missing
dep will be detected immediately.


> Do you still want me to gather them in the same folder?
> Is that mandatory, especially in order to find a sponsor?
> 
You can organise your SPEC building however you want, but that directory
shouldn't appear in the SPEC. When building from the Fedora GIT repo
(dist-git), all the SPEC, SOURCES and patches are at the base of the repo.
Random repo: https://src.fedoraproject.org/rpms/dav1d/tree/master SPEC and
sources file are at the base of the repo.

> And last question, if all is ok, am I ready to be sponsorized?
> 
I'm just reviewing your package for now, being spnsored is a separate process.
See https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

> Regards, Lewis ANESA.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux