Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ivtv - An iTVC15/16 and CX23415/16 driver https://bugzilla.redhat.com/show_bug.cgi?id=250971 ------- Additional Comments From kwizart@xxxxxxxxx 2007-10-26 09:05 EST ------- Ok, so i will close the other ivtv review - but there is still some problem with this package, and actually i cannot approve it because: NEED_WORK: MUST - Need to remove The perl Requires. MUST - In %prep Please uses sed instead as this will not work as perl have been removed of the minimal BR. (the two firsts lines in %prep could be removed) perl -pi -e's@CFLAGS = -D_GNU_SOURCE .*@CFLAGS = -D_GNU_SOURCE %{optflags}@' utils/Makefile And I wonder if some MUST - %build : add make -C utils %{?_smp_mflags} MUST - Description need to be improved to state that this is not the driver package but tools for the driver... SHOULD - You may prevent timestamps changes while using install -pm instead of mv - (but this is highly recommended by the reviewer, as this will keep the upstream date creation of files, instead of the build date in Fedora...) SHOULD - add %doc README* COPYING ChangeLog need to be added (at least README is useful to have info about kernel module info and how to build them...) SHOULD - License is missing whereas the package bundle it... But the license seems related to the kernel part (anyway it is the same, so i would say, pick it) SHOULD - This question is mainly an upstream question : the package bundles videodev2.h (which is the same as the one from /usr/include/linux/videodev2.h and as such do not give expected problem). But, some files are referring from the videodev2.h from the package whereas some others from kernel-headers... Maybe upstream have to choose one method... This isn't a problem as files are the same (but it may change...) - One Hight Remark, i wonder why we should keep compatibility -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review