https://bugzilla.redhat.com/show_bug.cgi?id=1857059 --- Comment #4 from Andrew Toskin <andrew@xxxxxxx> --- Oh, I'd forgotten the minor issue you pointed out, about DESTDIR being defined already in %make_install. Your suggestion of clearing the mock chroot fixed local fedora-review for me, and also allowed me to use the optimized %make_build for the delete_windows_files target. (Probably doesn't actually help much in this case, but probably doesn't hurt either, and removes a complaint from the generated review.txt.) Anyway, thanks for the review, and approval. I'll post the minor updates anyway. Spec URL: https://gitlab.com/terrycloth/packaging-bleachbit/uploads/9322a7b2b05abd0f08fe68745121ee0d/bleachbit.spec SRPM URL: https://gitlab.com/terrycloth/packaging-bleachbit/uploads/b2258932d8a70cd01fcb96bcc3551f93/bleachbit-4.0.0-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
