https://bugzilla.redhat.com/show_bug.cgi?id=1857059 --- Comment #2 from Andrew Toskin <andrew@xxxxxxx> --- Great, thanks! I've been having some trouble running fedora-review locally: Based on local files with `fedora-review --name`, it fails during mockbuild %build phase with "no job control", even though `fedpkg mockbuild` completes without error; and based on this online Bugzilla thread with `fedora-review --bug`, it fails to download the SRPM with Error 403, even though wget is able to download the same exact URL without issue, and I don't understand what's going wrong on my end... So I wasn't sure if fedora-review was going to even work here. I'm also not sure how to strip the shebangs from the non-executable files. I'd rather do it dynamically, based on `find`ing -not -executable files or something, rather than acting on CLI.py, GUI.py, and _platform.py explicitly... However, in the source, *most* Python files are marked as executable for some reason, and then the executability is removed where unneeded during %build or %install. So testing for executability during the %prep phase just doesn't catch the files. On the other hand, testing and stripping the shebangs *after* compilation causes a mismatch between the file timestamps for the source and compiled byte code, and rpmlint says this means the byte code will get recompiled every time the application launches... bleachbit.noarch: E: python-bytecode-inconsistent-mtime /usr/share/bleachbit/__pycache__/Update.cpython-39.opt-1.pyc 2020-07-15T09:21:59 /usr/share/bleachbit/Update.py 2020-07-15T09:22:00 The timestamp embedded in this python bytecode file isn't equal to the mtime of the original source file, which will force the interpreter to recompile the .py source every time, ignoring the saved bytecode... The best I can figure is, during %prep, to strip shebangs from *all* source Python files under ./bleachbit/, since all the files in that directory seem to install to /usr/share/. I don't know if that's guaranteed, though, so I kinda dislike this heuristic. Spec URL: https://gitlab.com/terrycloth/packaging-bleachbit/uploads/5e93cad32cd6f9e83c3d0141ea2d95ef/bleachbit.spec SRPM URL: https://gitlab.com/terrycloth/packaging-bleachbit/uploads/89d4a8f31ca4122b4bd8bd2317618e85/bleachbit-4.0.0-2.fc33.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
