https://bugzilla.redhat.com/show_bug.cgi?id=1838027 --- Comment #12 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Remove shebangs for zuul.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/zuul/ansible/base/library/command.py 644 /usr/bin/python3 zuul.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/zuul/ansible/base/library/zuul_console.py 644 /usr/bin/python3 - Add a logrotate file for your log See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_logrotate_config_file - Own this dir: [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/zuul Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "*No copyright* Apache License 2.0 GPL (v3.0)", "*No copyright* Apache License 2.0", "Expat License", "GPL (v3 or later)". 1645 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/zuul/review-zuul/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/zuul [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in zuul-scheduler, zuul-merger, zuul- web, zuul-executor, zuul-fingergw [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in zuul- webui , zuul-scheduler , zuul-merger , zuul-web , zuul-executor , zuul-fingergw , zuul-migrate [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: zuul-3.19.0-1.fc33.noarch.rpm zuul-webui-3.19.0-1.fc33.noarch.rpm zuul-scheduler-3.19.0-1.fc33.noarch.rpm zuul-merger-3.19.0-1.fc33.noarch.rpm zuul-web-3.19.0-1.fc33.noarch.rpm zuul-executor-3.19.0-1.fc33.noarch.rpm zuul-fingergw-3.19.0-1.fc33.noarch.rpm zuul-migrate-3.19.0-1.fc33.noarch.rpm zuul-doc-3.19.0-1.fc33.noarch.rpm zuul-3.19.0-1.fc33.src.rpm zuul.noarch: W: no-documentation zuul.noarch: W: non-standard-uid /etc/zuul/logging.conf zuul zuul.noarch: W: non-standard-gid /etc/zuul/logging.conf zuul zuul.noarch: W: non-standard-uid /etc/zuul/main.yaml zuul zuul.noarch: W: non-standard-gid /etc/zuul/main.yaml zuul zuul.noarch: W: non-standard-uid /etc/zuul/zuul.conf zuul zuul.noarch: W: non-standard-gid /etc/zuul/zuul.conf zuul zuul.noarch: E: non-readable /etc/zuul/zuul.conf 640 zuul.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/zuul/ansible/base/library/command.py 644 /usr/bin/python3 zuul.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/zuul/ansible/base/library/zuul_console.py 644 /usr/bin/python3 zuul.noarch: W: non-standard-uid /var/lib/zuul zuul zuul.noarch: W: non-standard-gid /var/lib/zuul zuul zuul.noarch: W: non-standard-uid /var/lib/zuul/.ssh zuul zuul.noarch: W: non-standard-gid /var/lib/zuul/.ssh zuul zuul.noarch: W: hidden-file-or-dir /var/lib/zuul/.ssh zuul.noarch: W: hidden-file-or-dir /var/lib/zuul/.ssh zuul.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul zuul.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul zuul.noarch: W: non-standard-uid /var/lib/zuul/keys zuul zuul.noarch: W: non-standard-gid /var/lib/zuul/keys zuul zuul.noarch: W: non-standard-uid /var/log/zuul zuul zuul.noarch: W: non-standard-gid /var/log/zuul zuul zuul.noarch: W: log-files-without-logrotate ['/var/log/zuul'] zuul.noarch: W: no-manual-page-for-binary zuul zuul.noarch: W: no-manual-page-for-binary zuul-bwrap zuul-webui.noarch: W: no-documentation zuul-scheduler.noarch: W: spelling-error %description -l en_US gearman -> gear man, gear-man, germane zuul-scheduler.noarch: W: no-documentation zuul-scheduler.noarch: W: no-manual-page-for-binary zuul-scheduler zuul-merger.noarch: W: no-documentation zuul-merger.noarch: W: no-manual-page-for-binary zuul-merger zuul-web.noarch: W: no-documentation zuul-web.noarch: W: no-manual-page-for-binary zuul-web zuul-executor.noarch: E: devel-dependency libffi-devel zuul-executor.noarch: E: explicit-lib-dependency libffi-devel zuul-executor.noarch: W: no-documentation zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/ansible zuul zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/ansible zuul zuul-executor.noarch: W: non-standard-uid /var/lib/zuul/executor zuul zuul-executor.noarch: W: non-standard-gid /var/lib/zuul/executor zuul zuul-executor.noarch: W: no-manual-page-for-binary zuul-executor zuul-executor.noarch: W: no-manual-page-for-binary zuul-manage-ansible zuul-fingergw.noarch: W: no-documentation zuul-fingergw.noarch: W: no-manual-page-for-binary zuul-fingergw zuul-migrate.noarch: W: no-documentation zuul-migrate.noarch: W: no-manual-page-for-binary zuul-migrate zuul-doc.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/zuul-doc/html/objects.inv 10 packages and 0 specfiles checked; 5 errors, 42 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
