Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-DBI-Dumper - Dump data from a DBI datasource to file Alias: perl-DBI-Dumper https://bugzilla.redhat.com/show_bug.cgi?id=241304 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-26 07:45 EST ------- Actually I was waiting for new upstream release but anyway as you have already added upstream clarification regarding license its ok now. Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 402bc1aacf4b39f318fa5b2bf47d123d DBI-Dumper-2.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01_use.......ok t/basic........ok t/dbidumper....Opening file: /tmp/QBa9Ygtduu 12 row(s) dumped. ok t/grammar......ok All tests successful. Files=4, Tests=131, 1 wallclock secs ( 1.10 cusr + 0.09 csys = 1.19 CPU) + Package perl-DBI-Dumper-2.01-2.fc8 -> Provides: C.so perl(DBI::Dumper) = 2.01 perl(DBI::Dumper::C) = 1.00 perl(DBI::Dumper::Grammar) perl(DBI::Dumper::PurePerl) perl(Parse::RecDescent::DBI::Dumper::Grammar) Requires: /usr/bin/perl libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl(:MODULE_COMPAT_5.8.8) perl(DBI) perl(DBI::Dumper) perl(DBI::Dumper::Grammar) perl(DBI::Dumper::PurePerl) perl(Inline) perl(Parse::RecDescent) perl(Time::HiRes) perl(strict) perl(vars) perl(warnings) rtld(GNU_HASH) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review