https://bugzilla.redhat.com/show_bug.cgi?id=1856557 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@xxxxxxxxx --- Comment #5 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- (In reply to Fabio Valentini from comment #4) > (In reply to Mat Booth from comment #3) > > Err... Probably. "8" is the last version before they added deps on stuff not > > in Fedora > > That's probably a good guess ... thanks for updating it. > It would probably be good to unbundle jbcrypt in the long run, but bundling > one (!) file for now is fine with me. > Not sure if it's necessary to ship the actual ISC license text with the > package, but I don't think the license requires it. > > > Yeah that's fair > > Since version was effectively bumped from 217 to 217.21, you should also > reset Release number to 1 (also in the Changelog message). > > > > > > > A comment in the .spec file that the package is built from the Jenkins fork > > > of trilead-ssh2 (and why?) is enough. > > > > Comment added > > Thanks! > > > See updated spec file: > > > > Spec URL: https://fedorapeople.org/~mbooth/reviews/trilead-ssh2.spec > > SRPM URL: > > https://fedorapeople.org/~mbooth/reviews/trilead-ssh2-217.21-14.fc33.src.rpm > > > I've ran the fedora-review tool and looked at the .spec file, and everything > seems to be in order, except one thing: > > One file is recognised by licensecheck to be under an "NTP License": > trilead-ssh2-trilead-ssh2-build-217-jenkins-21/src/com/trilead/ssh2/crypto/ > digest/MD5.java > > The license header in this class looks unlike anything I've seen before, and > I don't know how to categorize it. > NTP License is not listed under fedora's "Good" or "Bad" Licenses either ... NTP is just MIT: https://lists.fedoraproject.org/archives/list/legal@xxxxxxxxxxxxxxxxxxxxxxx/message/XSDPIYGEEIVMTJCKPGAL6UCC6DKJHZGK/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
